Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused anonymous namespace methods #41333

Merged
merged 1 commit into from
Feb 16, 2024
Merged

chore: remove unused anonymous namespace methods #41333

merged 1 commit into from
Feb 16, 2024

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 14, 2024 •
edited

Description of Change

Made redundant by #35603.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 14, 2024
@codebytere codebytere added semver/none no-backport and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 14, 2024
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 14, 2024
ckerr
ckerr approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last call to SetFrameSize() removed in 8a926ff

Last call to ViewDidMoveToSuperView() removed in f82a863

Nice catch!

@ckerr ckerr merged commit d4413a8 into main Feb 16, 2024
24 checks passed
@ckerr ckerr deleted the remove-unused-methods branch February 16, 2024 16:31
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 16, 2024

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @ckerr @jkleinsc