fix: check for draggable regions outside of main frame #41377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
semver/patch
1 task
codebytere
approved these changes
Feb 20, 2024
ckerr
approved these changes
Feb 20, 2024
|
Release Notes Persisted
|
|
I was unable to backport this PR to "29-x-y" cleanly; |
trop
bot
added
needs-manual-bp/29-x-y
and removed
target/29-x-y
|
@VerteDinde has manually backported this PR to "29-x-y", please check out #41388 |
deepak1556
reviewed
Feb 21, 2024
| // In Chrome, app regions are only supported in the main frame. | ||
| // However, we need to support draggable regions on other | ||
| // local frames/windows, so extend support beyond the main frame. | ||
| render_frame_->GetWebView()->SetSupportsAppRegion(true); |
There was a problem hiding this comment.
Reason for excluding child frames was devtools inspect gets broken, refs https://electronhq.slack.com/archives/CB6CG54DB/p1705578798763399?thread_ts=1705578659.730389&cid=CB6CG54DB. Please check if inspect continues to work with this change.
/cc @marekharanczyk
trop
bot
added
merged/29-x-y
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #41212
Fixes a bug introduced by crrev.com/c/4814003, where draggable regions on local frames (set using the app-region CSS property) are no longer automatically set and calculated unless an app uses a Window Controls Overlay or is Borderless. In the upstream CL, the change assumes that the local frame is a browser tab, and doesn't need draggable regions calculated; on Electron's side, we can't make that assumption.
This PR modifies the check to
SetSupportsAppRegion()to also check for frames outside of the main frame.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the
-webkit-app-region: dragproperty was not respected on some windows.