build: don't modify deps/v8/tools
paths
#41386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Prior to this,
generate_gn_filenames_json.py
replaced all files starting withdeps/v8
with references to the version of v8 we actually use insrc/v8
. However, this causes problems for the set of files indeps/v8/tools
as they're not compiled and Node.js depends on them directly with hardcoded paths. Up to now, I've just been manually changing this back after runninggenerate_gn_filenames_json.py
:electron/patches/node/build_add_gn_build_files.patch
Lines 1716 to 1726 in 3f4c55b
We should figure out a better long-term path for this but for now this prevents needing to undo the change during roll filename generation.
Checklist
npm test
passesRelease Notes
Notes: none