Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't modify deps/v8/tools paths #41386

Merged
merged 1 commit into from
Feb 22, 2024
Merged

build: don't modify deps/v8/tools paths #41386

merged 1 commit into from
Feb 22, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Prior to this, generate_gn_filenames_json.py replaced all files starting with deps/v8 with references to the version of v8 we actually use in src/v8. However, this causes problems for the set of files in deps/v8/tools as they're not compiled and Node.js depends on them directly with hardcoded paths. Up to now, I've just been manually changing this back after running generate_gn_filenames_json.py:

+ "deps/v8/tools/splaytree.mjs",
+ "deps/v8/tools/codemap.mjs",
+ "deps/v8/tools/consarray.mjs",
+ "deps/v8/tools/csvparser.mjs",
+ "deps/v8/tools/profile.mjs",
+ "deps/v8/tools/profile_view.mjs",
+ "deps/v8/tools/logreader.mjs",
+ "deps/v8/tools/arguments.mjs",
+ "deps/v8/tools/tickprocessor.mjs",
+ "deps/v8/tools/sourcemap.mjs",
+ "deps/v8/tools/tickprocessor-driver.mjs",

We should figure out a better long-term path for this but for now this prevents needing to undo the change during roll filename generation.

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from a team as a code owner February 20, 2024 20:59
@jkleinsc jkleinsc merged commit 136762b into main Feb 22, 2024
19 checks passed
@jkleinsc jkleinsc deleted the dont-modify-tools branch February 22, 2024 16:35
Copy link

release-clerk bot commented Feb 22, 2024

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants