Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update breaking changes language #41387

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Feb 21, 2024

Description of Change

This PR updates the language in breaking-changes.md to reflect better phrasing suggested by @erickzhao in the Electron 29 release blog post.

Checklist

Release Notes

Notes: none

@VerteDinde VerteDinde added semver/none target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 21, 2024
@VerteDinde VerteDinde requested a review from a team as a code owner February 21, 2024 00:33
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 21, 2024
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@github-actions github-actions bot added the target/30-x-y PR should also be added to the "30-x-y" branch. label Feb 21, 2024
@MarshallOfSound MarshallOfSound merged commit f350cce into main Feb 21, 2024
27 checks passed
@MarshallOfSound MarshallOfSound deleted the break-change-grammar branch February 21, 2024 19:25
Copy link

release-clerk bot commented Feb 21, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Feb 21, 2024

I have automatically backported this PR to "29-x-y", please check out #41398

@trop trop bot added in-flight/29-x-y and removed target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 21, 2024
@trop
Copy link
Contributor

trop bot commented Feb 21, 2024

I have automatically backported this PR to "30-x-y", please check out #41399

@trop trop bot added in-flight/30-x-y merged/30-x-y PR was merged to the "30-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/30-x-y in-flight/29-x-y labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants