Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webContents.print options should be optional #41467

Merged
merged 1 commit into from Feb 29, 2024
Merged

fix: webContents.print options should be optional #41467

merged 1 commit into from Feb 29, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Closes #41464.

Fixes an issue where webContents.print(options) failed if options was not passed or undefined is passed. This fixes that issue.

Checklist

Release Notes

Notes: Fixes an issue where webContents.print(options) failed if options was not passed or undefined is passed.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Feb 28, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 28, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 29, 2024
@jkleinsc jkleinsc merged commit d5912fd into main Feb 29, 2024
17 checks passed
@jkleinsc jkleinsc deleted the fix-print-options-optional branch February 29, 2024 15:19
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 29, 2024

Release Notes Persisted

Fixes an issue where webContents.print(options) failed if options was not passed or undefined is passed.

@trop trop bot mentioned this pull request Feb 29, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Feb 29, 2024

I have automatically backported this PR to "28-x-y", please check out #41478

@trop trop bot mentioned this pull request Feb 29, 2024
Merged
@trop trop bot removed the target/28-x-y PR should also be added to the "28-x-y" branch. label Feb 29, 2024
@trop trop bot mentioned this pull request Feb 29, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Feb 29, 2024

I have automatically backported this PR to "29-x-y", please check out #41479

@trop
Copy link
Contributor

trop bot commented Feb 29, 2024

I have automatically backported this PR to "30-x-y", please check out #41480

@trop trop bot added in-flight/29-x-y in-flight/30-x-y merged/29-x-y PR was merged to the "29-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/29-x-y in-flight/28-x-y labels Feb 29, 2024
@trop trop bot removed the in-flight/30-x-y label Mar 2, 2024
@zcbenz zcbenz mentioned this pull request Mar 4, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Mar 4, 2024

@zcbenz has manually backported this PR to "29-x-y", please check out #41501

@trop trop bot added the in-flight/29-x-y label Mar 4, 2024
@zcbenz zcbenz mentioned this pull request Mar 4, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Mar 4, 2024

@zcbenz has manually backported this PR to "28-x-y", please check out #41502

@trop trop bot added the in-flight/28-x-y label Mar 4, 2024
@zcbenz zcbenz mentioned this pull request Mar 4, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Mar 4, 2024

@zcbenz has manually backported this PR to "27-x-y", please check out #41503

@trop trop bot added the in-flight/27-x-y label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
in-flight/27-x-y in-flight/28-x-y in-flight/29-x-y merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Docs - webContents.print() options aren't optional
3 participants
@codebytere @ckerr @jkleinsc