Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing gin::Wrappable GetTypeName overrides #41512

Merged
merged 1 commit into from Mar 6, 2024
Merged

chore: add missing gin::Wrappable GetTypeName overrides #41512

merged 1 commit into from Mar 6, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Refs microsoft/vscode#192119 (comment).

Adds missing gin::Wrappable GetTypeName overrides.

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Mar 5, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 5, 2024
deepak1556
deepak1556 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codebytere codebytere merged commit 62331f5 into main Mar 6, 2024
16 of 17 checks passed
@codebytere codebytere deleted the add-missing-typenames branch March 6, 2024 11:45
@release-clerk Release Clerk
Copy link

release-clerk bot commented Mar 6, 2024

No Release Notes

This was referenced Mar 6, 2024
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 6, 2024

I have automatically backported this PR to "28-x-y", please check out #41529

@trop trop bot added in-flight/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Mar 6, 2024
@trop
Copy link
Contributor

trop bot commented Mar 6, 2024

I have automatically backported this PR to "29-x-y", please check out #41530

@trop
Copy link
Contributor

trop bot commented Mar 6, 2024

I have automatically backported this PR to "30-x-y", please check out #41531

@trop trop bot added in-flight/29-x-y in-flight/30-x-y merged/28-x-y PR was merged to the "28-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/28-x-y in-flight/30-x-y labels Mar 6, 2024
@trop trop bot removed the in-flight/29-x-y label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @deepak1556 @MarshallOfSound