Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve caption button appearance on Windows 11 #41561

Merged
merged 1 commit into from Mar 13, 2024
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 11, 2024

Description of Change

Refs CL:4428171
Refs https://issues.chromium.org/issues/40890030
Refs https://issues.chromium.org/issues/40265331

On Windows 11's Restore button, the top and right edges of the top
rounded square should be drawn with half-rounded linecaps, rather than
being flat at the ends.

Also, the stroke width applied to the caption buttons is too thin when
the current fractional scale is close to the next higher integer
scaling, E.g. 175% and 275%, but not 150% or 125%.

Checklist

Release Notes

Notes: Improved appearance of caption buttons on Windows 11 when using Windows Control Overlay.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/30-x-y PR should also be added to the "30-x-y" branch. labels Mar 11, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 11, 2024
@codebytere codebytere force-pushed the improve-win-cap-11 branch 2 times, most recently from f26dc47 to bacb9c0 Compare March 11, 2024 20:21
@codebytere codebytere requested a review from ckerr March 11, 2024 20:22
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 12, 2024
@jkleinsc jkleinsc merged commit 1840d7b into main Mar 13, 2024
15 checks passed
@jkleinsc jkleinsc deleted the improve-win-cap-11 branch March 13, 2024 14:58
Copy link

release-clerk bot commented Mar 13, 2024

Release Notes Persisted

Improved appearance of caption buttons on Windows 11 when using Windows Control Overlay.

@trop
Copy link
Contributor

trop bot commented Mar 13, 2024

I have automatically backported this PR to "30-x-y", please check out #41586

@trop trop bot added in-flight/30-x-y merged/30-x-y PR was merged to the "30-x-y" branch. and removed target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/30-x-y labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/30-x-y PR was merged to the "30-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants