Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error calling desktopCapturer.getSources twice #4158

Merged
merged 4 commits into from
Jan 20, 2016
Merged

Fix error calling desktopCapturer.getSources twice #4158

merged 4 commits into from
Jan 20, 2016

Conversation

kevinsawicki
Copy link
Contributor

There was a leftover reference to an undefined errorMessage variable that would throw an uncaught browser process exception when desktopCapturer.getSources() was called more than once from the render process.

Refs #3727

@jlord
Copy link
Contributor

jlord commented Jan 19, 2016

👍

1 similar comment
@zcbenz
Copy link
Member

zcbenz commented Jan 20, 2016

👍

zcbenz added a commit that referenced this pull request Jan 20, 2016
@zcbenz
Merge pull request #4158 from atom/desktop-capturer-error-message
54b5369 
Fix error calling desktopCapturer.getSources twice
@zcbenz zcbenz merged commit 54b5369 into master Jan 20, 2016
@zcbenz zcbenz deleted the desktop-capturer-error-message branch January 20, 2016 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinsawicki @jlord @zcbenz