fix: support recursive readdir in Asar files #41582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
changed the title
codebytere
force-pushed
the
readdir-in-asar
branch
from
62523f7
to
557c46b
Compare
codebytere
force-pushed
the
readdir-in-asar
branch
from
cf9cb56
to
d7d9232
Compare
codebytere
force-pushed
the
readdir-in-asar
branch
from
d7d9232
to
2da58bf
Compare
VerteDinde
approved these changes
Mar 14, 2024
|
Release Notes Persisted
|
This was referenced Mar 19, 2024
|
I have automatically backported this PR to "30-x-y", please check out #41625 |
trop
bot
added
in-flight/30-x-y
and removed
target/30-x-y
|
I have automatically backported this PR to "29-x-y", please check out #41626 |
trop
bot
added
in-flight/29-x-y
and removed
target/29-x-y
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #41549.
Refs nodejs/node#41439.
Adds missing support for the
recursiveoption infs.{readdir|readdirSync}as well asfs.promises.{readdir|readdirSync}in our fs Asar wrappers.As of now, one cannot pass both
withFileTypesandrecursive- I plan to add that in a follow-up.Checklist
npm testpassesRelease Notes
Notes: Added missing support for the
recursiveoption infs.{readdir|readdirSync}as well asfs.promises.{readdir|readdirSync}.