fix: missing badge text on Windows #41618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
jkleinsc
approved these changes
Mar 18, 2024
VerteDinde
approved these changes
Mar 18, 2024
|
Unrelated macOS failure - this PR is Windows-only. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "29-x-y", please check out #41628 |
trop
bot
added
in-flight/29-x-y
and removed
target/29-x-y
|
I have automatically backported this PR to "30-x-y", please check out #41629 |
trop
bot
added
in-flight/30-x-y
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #41589.
Refs CL:5053607
Fixes an issue where badge text set using the Badging API no longer appeared correctly on Windows. This happened because Chromium removed Skia
SkFontdefault value setting toskia::DefaultFont(), which meant it would be a null value and nothing would be painted properly. Also pulls in some updates fromchrome/browser/taskbar/taskbar_decorator_win.cc, where this function was initially adapted from to handle erstwhile Windows rendering issues.Before
After
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where badge text set using the Badging API no longer appeared correctly on Windows.