fix: normalize path before calling showItemInFolder and openPath

[piotrpdev]

Description of Change

Resolves #11617, e.g. before Windows Explorer wouldn't open when calling shell.showItemInFolder(fullPath) with a path that contains forward slashes. This PR makes the change of first normalizing the path that was passed in using NormalizePathSeparators().

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed shell.showItemInFolder not opening Windows Explorer if the passed path contains forward slashes

[piotrpdev]

Not sure why this Mac test is the only one that's failing; it doesn't seem relevant to me.

EDIT: Looks like this is happening to others so probably a false positive: #41577 (comment)

electron/spec/webview-spec.ts

Lines 2110 to 2142 in 7609156

	// TODO(miniak): figure out why this is failing on windows
	// TODO(vertedinde): figure out why this is failing on mac arm64
	ifdescribe(process.platform !== 'win32' && !isMacArm64)('<webview>.capturePage()', () => {
	it('returns a Promise with a NativeImage', async function () {
	this.retries(5);
	const src = 'data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E';
	await loadWebViewAndWaitForEvent(w, { src }, 'did-stop-loading');
	const image = await w.executeJavaScript('webview.capturePage()');
	expect(image.isEmpty()).to.be.false();
	// Check the 25th byte in the PNG.
	// Values can be 0,2,3,4, or 6. We want 6, which is RGB + Alpha
	const imgBuffer = image.toPNG();
	expect(imgBuffer[25]).to.equal(6);
	});
	it('returns a Promise with a NativeImage in the renderer', async function () {
	this.retries(5);
	const src = 'data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E';
	await loadWebViewAndWaitForEvent(w, { src }, 'did-stop-loading');
	const byte = await w.executeJavaScript(`new Promise(resolve => {
	webview.capturePage().then(image => {
	resolve(image.toPNG()[25])
	});
	})`);
	expect(byte).to.equal(6);
	});
	});

[piotrpdev]

Not sure who to ask for review on this (maybe @codebytere?), very small change anyway.

[codebytere]

Thanks for working on this! It also looks like shell.openPath might be subject to the same issue in the Windows impl? We should address that here as well if that's the case.

[codebytere]

thanks!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

Fixed shell.showItemInFolder not opening Windows Explorer if the passed path contains forward slashes

[trop]

I have automatically backported this PR to "28-x-y", please check out #41670

[trop]

I have automatically backported this PR to "30-x-y", please check out #41671

[trop]

I have automatically backported this PR to "29-x-y", please check out #41672