fix: don't do self-destroy in LibnotifyNotification::Dismiss()

[taoky]

Description of Change

Callers of Notification::Dismiss() assume that the notification instance is not deleted after the call, but this was not the case for LibnotifyNotification:

• Destroy() would get this deleted.
• notify_notification_close() in portal environment triggers LibnotifyNotification::OnNotificationClosed(), and finally calls Destroy()

This patch removes all Destroy() in Dismiss(), and adds a boolean to tell whether notify_notification_close() is running, to avoid crash under portal environment.

Fixes #40461.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed crash in Notification::Close() under libnotify 0.8.x with portal environment.

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[ckerr]

Thanks!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

Fixed crash in Notification::Close() under libnotify 0.8.x with portal environment.

[trop]

I was unable to backport this PR to "27-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "29-x-y", please check out #41707

[trop]

I have automatically backported this PR to "30-x-y", please check out #41708

[trop]

I have automatically backported this PR to "28-x-y", please check out #41709