New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use "id" instead of "label" for positions #41843
docs: use "id" instead of "label" for positions #41843
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs: lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of the Electron Docs Team
Congrats on merging your first pull request! 🎉🎉🎉 |
No Release Notes |
I have automatically backported this PR to "30-x-y", please check out #41859 |
Description of Change
The documentation for the
Menu
andMenuItem
classes describes the constructor optionsbefore
,after
,beforeGroupContaining
andafterGroupContaining
wrongly. It is said, that the placement would be relative to theMenuItem
containing the specified labels. The placement however is relative to aMenuItem
with the specified id as shown in the example in theMenu
classes documentation. This PR changes the descriptions to reflect this.Checklist
Release Notes
Notes: none