-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: setTitleBarOverlay
should be implemented on BaseWindow
#41960
Conversation
1947103
to
a70bfec
Compare
a70bfec
to
fa0e25d
Compare
Release Notes Persisted
|
I was unable to backport this PR to "30-x-y" cleanly; |
I was unable to backport this PR to "29-x-y" cleanly; |
I was unable to backport this PR to "31-x-y" cleanly; |
@codebytere has manually backported this PR to "31-x-y", please check out #42150 |
@codebytere has manually backported this PR to "30-x-y", please check out #42151 |
@codebytere has manually backported this PR to "29-x-y", please check out #42152 |
Description of Change
Closes #41938.
Moves
setTitleBarOverlay
to BaseWindow.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where
setTitleBarOverlay
didn't work as expected when called onBaseWindow
.