fix: View reordering on re-addition to same parent #42085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
3 tasks
nornagon
approved these changes
May 8, 2024
There was a problem hiding this comment.
NB https://issues.chromium.org/issues/41447071 intends to change this behavior in Chromium, but since this neatly fixes #42061 with no API change, seems fine. We should perhaps consider directly exposing ReorderChildView in a followup.
codebytere
force-pushed
the
match-upstream-view-reordering
branch
from
0728b7f
to
d1d49f2
Compare
|
Release Notes Persisted
|
This was referenced May 10, 2024
|
I have automatically backported this PR to "30-x-y", please check out #42115 |
trop
bot
added
in-flight/30-x-y
and removed
target/30-x-y
|
I have automatically backported this PR to "31-x-y", please check out #42116 |
trop
bot
added
in-flight/31-x-y
merged/31-x-y
Mrnikifabio
pushed a commit
to Mrnikifabio/electron
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #42077.
Closes #41974.
Closes #42061.
When the same view is added multiple times, we should match Chromium's behavior in
View::AddChildViewAtImpland re-order the view such that the view becomes the topmost view. Also adds tests.Checklist
npm testpassesRelease Notes
Notes: Fixed a crash when the same
WebContentsViewis added viaaddChildViewmultiple times.