Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: notification-spec link is broken in the notifications.md file #42240

Closed
3 tasks done
IsmaelMartinez opened this issue May 22, 2024 · 0 comments · Fixed by #42243
Closed
3 tasks done

[Bug]: notification-spec link is broken in the notifications.md file #42240

IsmaelMartinez opened this issue May 22, 2024 · 0 comments · Fixed by #42243
Labels
17-x-y bug 🪲 documentation 📓 status/reviewed A maintainer made an initial review but not reproduced the issue

Comments

@IsmaelMartinez
Copy link
Contributor

IsmaelMartinez commented May 22, 2024

Preflight Checklist

Electron Version

17.0.0

What operating system are you using?

macOS

Operating System Version

Sonoma 14.4

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

No response

Expected Behavior

When clicking the link in https://www.electronjs.org/docs/latest/tutorial/notifications#linux for Desktop Notifications Specification I would like to be directed to the right URL.

Actual Behavior

The link is broken. It points https://developer-old.gnome.org/notification-spec/ that is not available anymore.

Testcase Gist URL

No response

Additional Information

I think we got a couple of options.

  1. link to the waybak machine URL. I believe that specification is in disuse
  2. link to https://specifications.freedesktop.org/notification-spec/latest/ that seems to be the same specification (however I haven't compared the details)
  3. remove the link.

I got a PR ready for option 1, but it can be altered to fit a better solution.

Open to other solutions, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17-x-y bug 🪲 documentation 📓 status/reviewed A maintainer made an initial review but not reproduced the issue
Projects
None yet
2 participants