-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing fetch
-dependent interfaces in Node.js
#42419
Conversation
1320f48
to
5459638
Compare
5459638
to
5a401dc
Compare
Release Notes Persisted
|
I was unable to backport this PR to "29-x-y" cleanly; |
I have automatically backported this PR to "31-x-y", please check out #42453 |
I have automatically backported this PR to "30-x-y", please check out #42454 |
@danielweck already backported into v30 see #42454 |
Hello @codebytere, Thank you for the fix! I think that a similar patch must be applied to We use TestCafe to end-to-end test our Electron application and this breaks the Hammerhead web proxy that is used internally (this code block is executed by a web worker and triggers an error because |
Description of Change
Closes #42381.
Refs #41710
Fixes an issue where
fetch
dependent interfaces in Node.js were not defined whennodeIntegration
was enabled in some circumstances. I handled this partially in 9e4ae9c, but the problem extended slightly further and the same approach needed to be taken forFormData
,Request
, etc.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where
fetch
dependent interfaces in Node.js were not defined whennodeIntegration
was enabled in some circumstances.