Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showSaveDialog should replace extension when switching filters #4634

Closed
ricardomatias opened this issue Feb 29, 2016 · 6 comments
Closed

showSaveDialog should replace extension when switching filters #4634

ricardomatias opened this issue Feb 29, 2016 · 6 comments

Comments

@ricardomatias
Copy link

This is a common feature seen throughout several editors (gimp, inkscape, etc.), that when the user switches a filter the file path gets updated with the new filtered extension.
This is aimed at singular extensions and should be toggled on through the options object that showSaveDialog accepts. In the end, the method should also return the updated file path.

Example:
If the showSaveDialog is called with the file name hello.foo and then there's a filter for an extension called bar, the dialog should update the file name to hello.bar so the user can get a proper feedback to what type of file is he saving to.

@zcbenz
Copy link
Member

zcbenz commented Mar 3, 2016

Which operating system are you using?

@ricardomatias
Copy link
Author

Arch Linux. Should this be already working in other operating systems ?

@zcbenz zcbenz added bug platform/linux and removed blocked/need-info ❌ Cannot proceed without more information labels Mar 5, 2016
@zcbenz
Copy link
Member

zcbenz commented Mar 5, 2016

This is a regression on Linux.

@ricardomatias
Copy link
Author

I've downloaded 0.37.2 and it still has the same behavior as before. Is this functionality supposed to be working with other OS'es ?

@zcbenz
Copy link
Member

zcbenz commented Mar 15, 2016

I only implemented it on Linux. On other platforms this behavior is not expected in most apps as far as I know.

@bsivanov
Copy link

As of now (Electron 7.1.10), the extension chosen in the dialog is still (or again?) not added to the file name on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants