Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Chrome 49 #4714

Merged
merged 37 commits into from Mar 11, 2016
Merged

Upgrade to Chrome 49 #4714

merged 37 commits into from Mar 11, 2016

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Mar 8, 2016

Debug build compiles on:

  • OS X
  • Linux
  • Windows

Release build compiles on:

  • OS X
  • Linux
  • Windows

Tests passing on:

  • OS X
  • Linux
  • Windows

Features check list:

  • devtools
  • Pepper Flash
  • Widevine
  • printing

Merge:

@zcbenz zcbenz mentioned this pull request Mar 8, 2016
Merged
8 tasks
@z11h
Copy link

z11h commented Mar 8, 2016

What are some of the changes and improvements that this PR brings?

@anaisbetts anaisbetts mentioned this pull request Mar 8, 2016
Closed
2 tasks
zcbenz and others added 26 commits March 10, 2016 17:06
@zcbenz
Upgrade to Chrome 49
9bc9a1a
@zcbenz
Update crashpad to lastest branch
30643cf
@zcbenz
Fix the compilation errors from brightray and crashpad
3600645
@anaisbetts @zcbenz
Goodbye pdf.dll
8d021f2
@anaisbetts @zcbenz
startup helper is renamed
7f15a77
@anaisbetts @zcbenz
basictypes.h => macros.h
d2944c6
@anaisbetts @zcbenz
int32 => int32_t
4503aaf
@zcbenz
Fix compilation errors on OS X
5fae63a
@zcbenz
Fix cpplint warnings
f29d633
@zcbenz
Final pieces of int16 and .Pass()
a31cbd2
@zcbenz
Fix node integration not working
dd4d3db
@zcbenz
Fix passing Promise with remote
6de9c43 
Somehow using value.then.bind(value) would result in infinite loop,
could be bug of Chromium.
@zcbenz
Pending renderer process no longer has render view attached
bfc6d77
@zcbenz
Update printing code to latest
044daee
@zcbenz
Fix compilation errors on Linux
d36b8bc
@anaisbetts @zcbenz
We don't need Metro
a737baa
@anaisbetts @zcbenz
Update Get() => get(), Set() => reset()
60a2495
@anaisbetts @zcbenz
Use assignment operator since both sides are scoped now
12e9b7a
@anaisbetts @zcbenz
More type fixups
e835111
@anaisbetts @zcbenz
SetIsDraftMode no longer a thing, see https://groups.google.com/a/chr…
7b60ef6 
…omium.org/forum/m/#!topic/chromium-checkins/6qohfKmEYyg
@anaisbetts @zcbenz
Modifiers moved under UI
1c01e49
@anaisbetts @zcbenz
More boring fixups
f4ec369
@anaisbetts @zcbenz
Update pdf_to_emf_converter
e3af5de
@zcbenz
Create complete URLRequestContextGetter for URLRequestFetchJob
89f17e0 
The trivial one is causing crashes.
@zcbenz
Fix cpplint warnings
20466ba
@zcbenz
Fix compilation errors on Windows
cadd196
@zcbenz zcbenz force-pushed the chrome49 branch 2 times, most recently from 4d931fa to 052fc47 Compare March 10, 2016 13:37
@kidwm kidwm mentioned this pull request Mar 11, 2016
Closed
zcbenz added a commit that referenced this pull request Mar 11, 2016
@zcbenz
Merge pull request #4714 from atom/chrome49
6aec1e6 
Upgrade to Chrome 49
@zcbenz zcbenz merged commit 6aec1e6 into master Mar 11, 2016
@zcbenz zcbenz deleted the chrome49 branch March 11, 2016 12:39
@MrSaints
Copy link

Great job @zcbenz ! Thank you.

@kamesh-a
Copy link

Cool @zcbenz Thank you.

@dmythro
Copy link

dmythro commented Mar 11, 2016

Finally, thanks! Most of ES6 without preprocessors. Waiting for the next release! :)

@kevinsawicki
Copy link
Contributor

Awesome work @zcbenz @deepak1556 @paulcbetts ⬆️ 4️⃣ 9️⃣ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@zcbenz @z11h @MrSaints @kamesh-a @dmythro @kevinsawicki @anaisbetts @deepak1556