Publish the public API as a JSON object #7120
Conversation
| @@ -128,6 +129,8 @@ def copy_license(): | |||
| DIST_DIR) | |||
| shutil.copy2(os.path.join(SOURCE_ROOT, 'LICENSE'), DIST_DIR) | |||
|
|
|||
| def copy_api_json(): | |||
| shutil.copy2(os.path.join(OUT_DIR, 'electron-api.json'), DIST_DIR) | |||
There was a problem hiding this comment.
This should be a 2 space indent.
|
Travis CI is failing because it's using node 0.10 AppVeyor is failing on something that I think is unrelated:
@kevinsawicki @zcbenz any tips on how I can isolate this new stuff to only run in the necessary CI environment(s)? |
| @@ -78,6 +78,7 @@ def main(): | |||
| upload_electron(github, release, os.path.join(DIST_DIR, DIST_NAME)) | |||
| upload_electron(github, release, os.path.join(DIST_DIR, SYMBOLS_NAME)) | |||
| if PLATFORM == 'darwin': | |||
| upload_electron(github, release, os.path.join(DIST_DIR, 'electron-api.json')) | |||
There was a problem hiding this comment.
This line is over 80 characters and causing script/pylint.py to fail.
| @@ -78,6 +78,8 @@ def main(): | |||
| upload_electron(github, release, os.path.join(DIST_DIR, DIST_NAME)) | |||
| upload_electron(github, release, os.path.join(DIST_DIR, SYMBOLS_NAME)) | |||
| if PLATFORM == 'darwin': | |||
| upload_electron(github, release, os.path.join(DIST_DIR, | |||
|
All CI builds are passing but Travis, which is giving this error: I tried a manual rebuild but it seems to be failing in the same spot. |
|
@zeke It looked like travis was having some issues this morning (other builds have been failing with this issue as well) |
|
This looks good to me, feel free to merge when you think it is ready. |
This is a followup to #6408, a closed PR which I was unable to re-open after a force-push. Please see that PR for context on this effort.
I finished everything in the electron-docs-linter milestone and with @kevinsawicki's help I've added the necessary code to upload the generated JSON object along with the Electron release.
@zcbenz this is ready for review.