Allow custom window level when sending window to top

[adammeyer]

This allows for a custom window level to be set when sending a window to the top.

win.setAlwaysOnTop(true, 102);

This can be used when the NSFloatingWindowLevel isn't high enough. I have used this to put a window above the top menu bar.

[kevinsawicki]

Pretty cool, mind updating the docs as well for this?

https://github.com/electron/electron/blob/master/docs/api/browser-window.md#winsetalwaysontopflag

[kevinsawicki]

Might be useful to include the possible values as well of these https://developer.apple.com/reference/appkit/nswindow/1664726-window_levels#symbols in the docs

[adammeyer]

@kevinsawicki Thanks! I added the details to the docs. Currently the parameter is an integer, not a mac window level constant. I like that idea, but I'm not sure how to take a constant in as a string and then convert it to the constant value in the native window controller.

[kevinsawicki]

I like that idea, but I'm not sure how to take a constant in as a string and then convert it to the constant value in the native window controller.

I can help you update it, what do you think about these string value names for the different integer values:

• NSNormalWindowLevel -> 'normal'
• NSFloatingWindowLevel -> 'floating'
• NSTornOffMenuWindowLevel -> 'torn-off-menu'
• NSModalPanelWindowLevel -> 'modal-panel'
• NSMainMenuWindowLevel -> 'main-menu'
• NSStatusWindowLevel -> 'status'
• NSPopUpMenuWindowLevel -> 'pop-up-menu'
• NSScreenSaverWindowLevel -> 'screen-saver'
• NSDockWindowLevel -> 'dock'

[adammeyer]

Looks great! I committed my best attempt. I'm getting some errors with the string declarations.

[kevinsawicki]

@adammeyer I pushed a change that gets things compiling.

When testing this though it is kind of hard to tell the differences between these levels, they seem to all be very similar.

Can you expand on how you plan to use it a bit?

[adammeyer]

I would like to open a window that fills the screen and is above the menu bar, without the animations that come with making a window "fullscreen". Kind of like showing a PowerPoint presentation.

I could also see it being used if you wanted multiple windows to always be on top, but one to be the top most of those.

[kevinsawicki]

I would like to open a window that fills the screen and is above the menu bar

Which level allows this? Curious to test it locally.

[adammeyer]

I believe screen-saver.

[adammeyer]

Yes, just confirmed it is screen-saver

[adammeyer]

@kevinsawicki Anything left to add?

[zcbenz]

👍

[matheuss]

@adammeyer I just wanted to tell you that you're my hero – this will be very useful on wulkano/kap 😄