frame: false not working on Win2k8 Server VM (Chrome provided frame) #799
Comments
frankhale
changed the title
|
Okay so I just played around with this on Windows 8.1 and I put the Atom-Shell exe in compatibility mode for XP Service Pack 3 and when I run a frameless window it shows that blue Chrome provided frame even though frame: false is set. |
|
Isn't Server 2k8 basically Vista? Atom officially supports Win 7 + |
|
I'm not sure. Atom-Shell seems to work fine on Win2k8. That frame though is coming from Chrome right? I've seen that same frame on Linux on the debug tools window. It's a non-native frame as far as I can tell. |
|
Whoops, sorry. I was looking at a page full of notifications and thought this was on the atom/atom repo, not atom-shell. Ignore me! |
|
Here is the requisite issue for the Linux dev tools that I posted a while back. It's been closed and I'm going to go dig into the code and see how it was fixed.
|
|
No worries @thedaniel =) |
|
I suspect that this bug would also repro on other modern Server SKUs of Windows too (i.e. Server 2012 or 2012 R2) |
|
In native_window_views.cc the remove_standard_frame is being set based on if it's frameless or not. This seems to have no effect and Chrome uses it's window frame to decorate the window. Apparently there is a TYPE_WINDOW_FRAMELESS option for the InitParams. I've tried this and it indeed makes the Chrome blue frame go away and the window is frameless but it has some nasty side effects of crashing Atom. reference: http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/widget.h struct VIEWS_EXPORT InitParams {
enum Type {
TYPE_WINDOW, // A decorated Window, like a frame window.
// Widgets of TYPE_WINDOW will have a NonClientView.
TYPE_PANEL, // Always on top window managed by PanelManager.
// Widgets of TYPE_PANEL will have a NonClientView.
TYPE_WINDOW_FRAMELESS,
// An undecorated Window.
TYPE_CONTROL, // A control, like a button.
TYPE_POPUP, // An undecorated Window, with transient properties.
TYPE_MENU, // An undecorated Window, with transient properties
// specialized to menus.
TYPE_TOOLTIP,
TYPE_BUBBLE,
TYPE_DRAG, // An undecorated Window, used during a drag-and-drop to
// show the drag image.
};What I tried in the NativeWindowViews constructor views::Widget::InitParams params;
params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
params.bounds = bounds;
params.delegate = this;
if(has_frame_)
params.type = views::Widget::InitParams::TYPE_WINDOW;
else
params.type = views::Widget::InitParams::TYPE_WINDOW_FRAMELESS;
// Tried it with this guy commented out as well
params.remove_standard_frame = !has_frame_;I'm going to keep digging and see what I can find out. |
|
I may be making some progress here to suppress the Chrome frame. I can at least get it to force a system frame but I can't tell the Chrome frame to go away yet.
|
|
Success... And it doesn't break Windows 8.1. w00t!
|
|
@frankhale Nice! We were hitting that bug too afaik |
|
@zcbenz, I need a sanity check on this alleged fix. What I did,,, at the bottom of the NativeWindowViews constructor I added a couple lines of code to force native window. Should this be done for all operating systems or just Windows? I'm assuming you don't ever want an Atom-Shell app to display the Chrome blue window titlebar? atom\browser\native_window_views.cc NativeWindowViews::NativeWindowViews(content::WebContents* web_contents,
const mate::Dictionary& options)
: NativeWindow(web_contents, options),
window_(new views::Widget),
web_view_(inspectable_web_contents()->GetView()->GetView()),
menu_bar_autohide_(false),
menu_bar_visible_(false),
menu_bar_alt_pressed_(false),
keyboard_event_handler_(new views::UnhandledKeyboardEventHandler),
use_content_size_(false),
resizable_(true) {
// CODE OMITTED...
if(has_frame_) {
window_->set_frame_type(views::Widget::FrameType::FRAME_TYPE_FORCE_NATIVE);
window_->FrameTypeChanged();
}
window_->UpdateWindowIcon();
window_->CenterWindow(bounds.size());
Layout();
}In addition to that on Windows the frame view was not being initialized unless AeroGlass is enabled. I think we can't assume that Aero Glass will be enabled especially if people are running Atom-Shell on a VM where it may not be possible to enable Aero Glass due to graphical limitations. views::NonClientFrameView* NativeWindowViews::CreateNonClientFrameView(
views::Widget* widget) {
#if defined(OS_WIN)
//if (ui::win::IsAeroGlassEnabled()) {
WinFrameView* frame_view = new WinFrameView;
frame_view->Init(this, widget);
return frame_view;
//}
#elif defined(OS_LINUX)
// CODE OMITTED...
#endif
return NULL;
}This change doesn't seem to cause any ill effects on Windows 8.1 for me. |
|
Although I did not mention it, got carried away this also resolves the frameless view as well. |
If it works on Linux then it is fine to keep it for all operating systems.
Using And pull requests are welcomed :) |
|
I didn't want to submit too many pull requests because I know you are busy. I'll submit one tomorrow for this issue. |
|
Definitely err on the side of more PRs, the worst thing that can happen is that they sit for a while before they get reviewed. |
|
Before I send a PR for this I'll try it on Linux. |
|
Okay my ArchLinux system has the current version of Clang and I cannot build Atom-Shell. I'm going to submit this PR with the exception that I need somebody with a working Linux system to build and test this. The change is quite simple so should be very simple to see if it works. I'm currently building the change on my Windows box before I submit a PR. |
|
Fixed by #815. |
I have a Win2k8 VM and Atom-Shell doesn't use native frames for windows but instead uses the Chrome provided blue frame. That is all fine and dandy and doesn't bother me but if I set the frame to false the Chrome provided frame still shows. I've modified the default_app to set frame: false. (see screenshot below)
Atom-Shell 0.19.1
The text was updated successfully, but these errors were encountered: