Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom margins in marginsType when using printToPDF #8138

Closed
destan opened this issue Dec 3, 2016 · 1 comment
Closed

Custom margins in marginsType when using printToPDF #8138

destan opened this issue Dec 3, 2016 · 1 comment
Labels
component/printing enhancement ✨

Comments

@destan
Copy link
Contributor

destan commented Dec 3, 2016 •
edited

When using webContents.printToPDF(options, callback) there are only 3 options of marginsType available however in chrome there are actually 4 the 4th being the custom.

screenshot from 2016-12-04 00-29-25

Can we set custom margin types with printToPDF? Since Chrome doesn't support page margin boxes when printing (or generating pdf) this custom print margins are essential while generating pdf.
@stale stale bot added the wontfix label Mar 15, 2017
@zeke zeke removed wontfix labels Mar 15, 2017
@zcbenz
Copy link
Member

zcbenz commented May 31, 2017

I'm merging this to #7849.

@zcbenz zcbenz closed this as completed May 31, 2017
@destan destan mentioned this issue May 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/printing enhancement ✨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zeke @destan @zcbenz @kevinsawicki