Backspace can not erase the last one character during Japanese IME conversion (macOS) #9173

Thomas101 · 2017-04-12T13:23:47Z

Electron version: 1.6.2, 1.6.6, not 1.4.16
Operating system: macOS 10.12.2 Sierra, macOS 10.12.4

Expected behavior

When inputting Japanese sentences using the Japanese IME (Input Method Editor) to convert alphabets to Japanese (CJK) characters you should be able to delete each character in turn by pressing backspace

Actual behavior

The very last character always needs two backspace presses

How to reproduce

Clone my version of electron starter

$ git clone https://github.com/wavebox/electron-quick-start -b japanese_delete_bug
$ npm install
$ npm start

Go to System preferences > Language & Region
Press the + to add a language and add Japanese (about a whole scroll down for me)
When prompted use your current language as the primary language
Launch the repository clone of quickstart (above)
Using the flag icon in the mac top bar change your current input method to Katakana
Click in the input field, type a few characters, then start hitting backspace
To delete the last character you have to hit backspace twice

Some other things about this I've found...

Remove the webview tag from the page and it works as expected (input field is not within the webview, but does also affect it there)
Issue is reproducible in 1.6.2 & 1.6.6 (maybe others inbetween)
Issue not apparent in 1.4.16
Some gifs of the behaviour in the original issue

The text was updated successfully, but these errors were encountered:

kevinsawicki · 2017-04-24T20:10:56Z

I reported a related issue upstream where when the input is inside the <webview> tag, two backspaces are required to delete the last character, https://bugs.chromium.org/p/chromium/issues/detail?id=714771

kevinsawicki · 2017-05-22T21:03:06Z

This will be fixed in the next Electron release, 1.7.2

Thomas101 · 2017-05-24T07:52:17Z

Awesome thank you :)

kevinsawicki · 2017-07-10T21:32:23Z

Reopening this since the original fix introduced #9709 on 1.7.x.

Will revisit in 1.8.x since we can land further patches from upstream Chrome that have been applied since this original fix.

achimnol · 2017-07-17T02:27:37Z

This seems to be affecting the current releases of Slack, Microsoft Teams, and some other Electron-based apps. Subscribing this issue with hopes to be fixed soon!

gerges-zz · 2017-10-12T19:58:21Z

I'm having a hard time understanding the status of this issue. As far as i can tell this is fixed in 1.6.x, broken in 1.7.x, and ideally will be fixed again in 1.8.x? Is that correct?

chenerzhang · 2018-01-10T06:32:55Z

any update?

chenerzhang · 2018-01-26T13:39:25Z

You can test this way. My trouble is Chinese IME and this can help me solve this problem on mac.

<!DOCTYPE html>
<html>
<head>
  <meta charset="UTF-8">
  <title>Hello World!</title>
  <style>
    *,
    *::before,
    *::after {
      box-sizing: border-box;
      margin: 0;
      padding: 0;
    }

    html,
    body {
      width: 100%;
      height: 100%;
    }

    body {
      display: flex;
      flex-direction: column;
    }

    webview {
      flex: 1;
      width: 100%;
    }

    input {
      height: 300px;
    }
  </style>
</head>

<body>
  <textarea rows="10" id="input"></textarea>
  <webview src="https://www.google.com"></webview>
  <script>
    // You can also require other files to run in this process
    require('./renderer.js');
    const { exec, spawn } = require('child_process');

    const $input = document.querySelector('#input');
    let inputTimeStamp = 0;
    let inputNums = 0;
    let delta = 1;
    let backspaceKeydownTimestamp = 0;
    $input.addEventListener('input', (e) => {
      inputTimeStamp = e.timeStamp;
      inputNums += delta;
    });
    $input.addEventListener('keyup', (e) => {
      if (e.key === 'Backspace') {
        let deleteFlag = false;
        // slow delete detect
        if (inputTimeStamp === -1) {
          deleteFlag = true;
          delta = 1;
          inputTimeStamp = 0;
          exexDelete();
        }
        // quick delete detect
        if (!deleteFlag && inputNums === 1 && e.timeStamp - backspaceKeydownTimestamp < 60) {
          inputNums = 0;
          exexDelete();
        }
      }
      inputTimeStamp = -1;
    });
    $input.addEventListener('keydown', (e) => {
      if (e.key === 'Backspace') {
        backspaceKeydownTimestamp = e.timeStamp;
        delta = -1;
      } else {
        delta = 1;
      }
    });
    $input.addEventListener('compositionstart', () => {
      inputTimeStamp = 0;
      inputNums = 0;
      delta = 1;
      backspaceKeydownTimestamp = 0;
    });
    function exexDelete() {
      const ps = spawn('osascript');
      ps.stdin.write(`
      tell application "System Events"
        keystroke ascii character 8
      end tell
      `);
      ps.stdin.end();
    }
  </script>
</body>

</html>

zjfjiayou · 2018-01-29T13:16:28Z

I have encountered the same problem in this version 1.7.11. The language is Chinese.

aceimnorstuvwxz · 2018-02-13T10:28:50Z

same problem on 1.7.10, Chinese

kenan2002 · 2018-04-11T10:47:54Z

I'm in trouble with this issue, too.
I see that this issue has been fixed in Electron 2.0 beta which is based on Chromium 61. Is there any plan on an Electron 1.x version based on Chromium 61 or above so that we can fix this issue without any impact of breaking-changed API?

zoubingwu · 2018-04-11T13:26:44Z

Yes, we really need this to be fixed, pls make it happen in 1.8.x if possible, plsssssssssss
🙇

codebytere · 2018-09-24T04:44:59Z

We are no longer implementing bugfixes for versions of Electron <= 1.7.x, so i'm going to close this issue but if it is still persisting in more recent versions of Electron we can certainly reopen it!

tete1030 · 2018-12-03T11:01:44Z

We are no longer implementing bugfixes for versions of Electron <= 1.7.x, so i'm going to close this issue but if it is still persisting in more recent versions of Electron we can certainly reopen it!

The version 2.0.12 is still broken on this issue after it was fixed in 2.0 beta. VSCode's latest version 1.29.1 is using Electron 2.0.12. Please see:
microsoft/vscode#37114 (comment)

I'm using macOS 10.14.1

nornagon · 2018-12-03T19:28:57Z

Is there any chance you could verify this on 3.0.x or 4.0.x-beta? Perhaps with Electron Fiddle?

tete1030 · 2018-12-04T06:17:33Z

Sorry, while I can reproduce this issue in v1.8.8, I cannot reproduce it in 2.0.7, 2.0.12, 3.0.10, 4.0.0-beta.8 .
I tested them with Electron Fiddle with the following code using macOS Pinyin input method.

<webview src="data:text/html,<input type=text />"></webview>

I'm also reporting this result to the vscode issue.

rebornix · 2018-12-04T17:51:11Z

@tete1030 input in webview is not no longer affected while input outside of webview is still running into this issue.

Sample html to reproduce

<input />
<webview src="data:text/html,<input type=text />"></webview>

The issue is gone in 3.0.10 and 4.0.0-beta.8 but IMO we should have a fix for 2.x

tete1030 · 2018-12-05T02:27:22Z

The fix is between 3.0.0-beta.5 and 3.0.0-beta.6

sofianguy · 2019-08-09T04:03:55Z

Given this is reported as fixed in 4.x, I will close this issue. We are no longer supporting versions earlier than 4.x

Thomas101 mentioned this issue Apr 12, 2017

Backspace can not erase the last one character during Japanese IME conversion (macOS) wavebox/waveboxapp#44

Closed

deepak1556 added bug/regression ↩️ A new version of Electron broke something platform/macOS labels Apr 13, 2017

poiru added the component/webview label Apr 13, 2017

bpasero mentioned this issue Apr 17, 2017

unconfirmed text of CJK IME collapse to one character microsoft/vscode#24557

Closed

rebornix mentioned this issue Apr 19, 2017

Backspace can not erase the last one character during Chinese/Japanese IME conversion (macOS) microsoft/vscode#24981

Closed

kevinsawicki added the blocked label Apr 27, 2017

kevinsawicki mentioned this issue May 22, 2017

Backport macOS IME backspace fix electron/libchromiumcontent#300

Merged

kevinsawicki closed this as completed in electron/libchromiumcontent#300 May 22, 2017

Kurom96 mentioned this issue Jun 9, 2017

Only the first letter will be alphabetic when input Japanese. (using Japanese IME) #9709

Closed

kevinsawicki mentioned this issue Jul 10, 2017

Upgrade to electron/libchromiumcontent@8cfd08f84e4 #9967

Merged

kevinsawicki reopened this Jul 10, 2017

deepak1556 mentioned this issue Jul 18, 2017

backport fix for accented letter input resulting double letters in webview electron/libchromiumcontent#323

Merged

jkleinsc mentioned this issue Sep 6, 2017

Backport macOS IME backspace fix for 1.6.x #10450

Merged

rebornix mentioned this issue Nov 16, 2017

Using IME with markdown preview enabled, press ESC/BACKSPACE leads in control characters microsoft/vscode#37114

Closed

deepak1556 added blocking-stable chromium and removed blocked labels Jan 29, 2018

deepak1556 self-assigned this Jan 29, 2018

deepak1556 removed the blocking-stable label Jan 30, 2018

jkleinsc added the version/1.6.x label Feb 6, 2018

aceimnorstuvwxz mentioned this issue Feb 13, 2018

webview's input area remain a char after delete under Pinyin IME #11909

Closed

aceimnorstuvwxz mentioned this issue Feb 13, 2018

你好，https://github.com/electron/electron/issues/9173 zjfjiayou/react-native-mind#3

Closed

aslend mentioned this issue Apr 20, 2018

Backspace can not erase the last one character during Japanese IME conversion (macOS) RocketChat/Rocket.Chat.Electron#709

Closed

2 tasks

deepak1556 removed their assignment Aug 28, 2018

codebytere closed this as completed Sep 24, 2018

nornagon added the 2-0-x label Dec 3, 2018

nornagon reopened this Dec 3, 2018

wangduanduan mentioned this issue Feb 21, 2019

vscode控制字符引起的问题以及解决思路 wangduanduan/wangduanduan.github.io#158

Closed

sofianguy closed this as completed Aug 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backspace can not erase the last one character during Japanese IME conversion (macOS) #9173

Backspace can not erase the last one character during Japanese IME conversion (macOS) #9173

Thomas101 commented Apr 12, 2017

kevinsawicki commented Apr 24, 2017

kevinsawicki commented May 22, 2017

Thomas101 commented May 24, 2017

kevinsawicki commented Jul 10, 2017

achimnol commented Jul 17, 2017

gerges-zz commented Oct 12, 2017

chenerzhang commented Jan 10, 2018

chenerzhang commented Jan 26, 2018

zjfjiayou commented Jan 29, 2018

aceimnorstuvwxz commented Feb 13, 2018

kenan2002 commented Apr 11, 2018

zoubingwu commented Apr 11, 2018

codebytere commented Sep 24, 2018

tete1030 commented Dec 3, 2018

nornagon commented Dec 3, 2018

tete1030 commented Dec 4, 2018

rebornix commented Dec 4, 2018 •

edited

Loading

tete1030 commented Dec 5, 2018

sofianguy commented Aug 9, 2019

Backspace can not erase the last one character during Japanese IME conversion (macOS) #9173

Backspace can not erase the last one character during Japanese IME conversion (macOS) #9173

Comments

Thomas101 commented Apr 12, 2017

Expected behavior

Actual behavior

How to reproduce

kevinsawicki commented Apr 24, 2017

kevinsawicki commented May 22, 2017

Thomas101 commented May 24, 2017

kevinsawicki commented Jul 10, 2017

achimnol commented Jul 17, 2017

gerges-zz commented Oct 12, 2017

chenerzhang commented Jan 10, 2018

chenerzhang commented Jan 26, 2018

zjfjiayou commented Jan 29, 2018

aceimnorstuvwxz commented Feb 13, 2018

kenan2002 commented Apr 11, 2018

zoubingwu commented Apr 11, 2018

codebytere commented Sep 24, 2018

tete1030 commented Dec 3, 2018

nornagon commented Dec 3, 2018

tete1030 commented Dec 4, 2018

rebornix commented Dec 4, 2018 • edited Loading

tete1030 commented Dec 5, 2018

sofianguy commented Aug 9, 2019

rebornix commented Dec 4, 2018 •

edited

Loading