Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship pdb files with windows releases #112

Closed
mcolyer opened this issue Oct 25, 2013 · 5 comments
Closed

Ship pdb files with windows releases #112

mcolyer opened this issue Oct 25, 2013 · 5 comments

Comments

@mcolyer
Copy link
Contributor

mcolyer commented Oct 25, 2013

@paulcbetts suggests that it will make debugging dramatically easier.
@anaisbetts
Copy link
Contributor

No reason not to if we're open-source, they compress really well so size isn't an issue

@mcolyer
Copy link
Contributor Author

mcolyer commented Oct 25, 2013

Also we need the resources directory that's in the osx build in the windows build as well.

@zcbenz zcbenz closed this as completed in 198b52b Oct 26, 2013
@mcolyer
Copy link
Contributor Author

mcolyer commented Oct 28, 2013

Thanks for including those, what about the resources directory? I think it's necessary as it includes the JS API stubs for atom-shell but maybe I'm misunderstanding something here.

@zcbenz
Copy link
Member

zcbenz commented Oct 28, 2013

It's also fixed in 3ddba90.

@mcolyer
Copy link
Contributor Author

mcolyer commented Oct 28, 2013

Awesome, I missed that commit when I went looking for it.

kevinsawicki pushed a commit that referenced this issue May 9, 2017
@zcbenz
Merge pull request #112 from atom/devtools-load-network-resources
9cc7d7f 
Fix networking requests not loading in devtools
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@zcbenz
Merge pull request #112 from atom/devtools-load-network-resources
44ba4e8 
Fix networking requests not loading in devtools
kevinsawicki pushed a commit that referenced this issue Jul 6, 2017
@ungoldman
Merge pull request #112 from mitchhentges/master
e644df6 
Make npm badge link to package page
@abalter abalter mentioned this issue Jul 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anaisbetts @mcolyer @zcbenz