Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle dev tools fails if closed from x icon #27

Closed
kevinsawicki opened this issue Jun 17, 2013 · 3 comments
Closed

Toggle dev tools fails if closed from x icon #27

kevinsawicki opened this issue Jun 17, 2013 · 3 comments

Comments

@kevinsawicki
Copy link
Contributor

  1. Toggle dev tools using View > Toggle Developer Tools menu
  2. Close dev tools from x icon on top left
  3. Toggle dev tools using View > Toggle Developer Tools menu

Dev tools does not appear again.
@aroben
Copy link
Contributor

aroben commented Jun 17, 2013

This seems related to electron-archive/brightray#21

@zcbenz
Copy link
Member

zcbenz commented Jun 18, 2013

Yes they are the same issue, currently the toggleDevTools is emulated by remembering the open state, and it would fail when devtools is closed from GUI:
https://github.com/atom/atom-shell/blob/master/browser/api/lib/browser-window.coffee#L15

@zcbenz zcbenz mentioned this issue Nov 2, 2013
Closed
@zcbenz zcbenz closed this as completed in dc1a8b6 Nov 5, 2013
@kevinsawicki
Copy link
Contributor Author

❇️

@ns ns mentioned this issue Feb 6, 2017
Closed
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@aroben
Update to Chrome 30
907a1d0 
* vendor/libchromiumcontent a56056d...bfb2d7b (1):
  > Merge pull request #27 from brightray/chrome-30
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@aroben
Update to Chrome 30
0575987 
* vendor/libchromiumcontent a56056d...bfb2d7b (1):
  > Merge pull request #27 from brightray/chrome-30
@avengerweb avengerweb mentioned this issue Oct 13, 2017
Closed
MarshallOfSound pushed a commit that referenced this issue May 1, 2018
@ckerr
Merge pull request #27 from electron/fix-to-details-string-call
3edb1ee 
Fix Value::ToDetailString() call
@ckerr ckerr mentioned this issue Oct 24, 2018
Closed
@wujinli wujinli mentioned this issue Jan 31, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zcbenz @kevinsawicki @aroben