Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot redefine property: id #43

Closed
kevinsawicki opened this issue Jul 26, 2013 · 1 comment
Closed

Error: Cannot redefine property: id #43

kevinsawicki opened this issue Jul 26, 2013 · 1 comment

Comments

@kevinsawicki
Copy link
Contributor

Got this weird error once or twice while launching atom from a custom url.

[0725/200713:INFO:CONSOLE(51)] "TypeError: Cannot redefine property: id
    at Function.defineProperty (native)
    at IDWeakMap.objectsWeakMap.add (/Applications/Atom.app/Contents/Resources/browser/atom/objects-registry.js:74:12)
    at Object.exports.add (/Applications/Atom.app/Contents/Resources/browser/atom/objects-registry.js:100:22)
    at valueToMeta (/Applications/Atom.app/Contents/Resources/browser/atom/rpc-server.js:36:38)
    at Ipc.<anonymous> (/Applications/Atom.app/Contents/Resources/browser/atom/rpc-server.js:88:29)
    at Ipc.EventEmitter.emit (events.js:106:17)
    at process.<anonymous> (/Applications/Atom.app/Contents/Resources/browser/api/lib/ipc.js:41:27)
    at process.EventEmitter.emit (events.js:106:17)", source: /Applications/Atom.app/Contents/Resources/renderer/api/lib/remote.js (51)
[0725/200713:INFO:CONSOLE(22)] "Error: Cannot redefine property: id
    at metaToValue (/Applications/Atom.app/Contents/Resources/renderer/api/lib/remote.js:52:15)
    at Object.exports.require (/Applications/Atom.app/Contents/Resources/renderer/api/lib/remote.js:124:12)
    at Object.<anonymous> (/Users/nathansobo/github/atom/src/app/atom.coffee:25:16)
    at Object.<anonymous> (/Users/nathansobo/github/atom/src/app/atom.coffee:466:4)
    at Module._compile (module.js:467:26)
    at Object.require.extensions..coffee (/Users/nathansobo/github/atom/node_modules/coffee-cache/lib/coffee-cache.js:48:17)
    at Module.load (module.js:367:32)
    at Function.Module._load (module.js:323:12)
    at Module.require (module.js:375:17)
    at require (module.js:391:17)
    at Object.<anonymous> (/Users/nathansobo/github/atom/src/packages/collaboration/lib/bootstrap.coffee:4:3)
    at Object.<anonymous> (/Users/nathansobo/github/atom/src/packages/collaboration/lib/bootstrap.coffee:89:4)
    at Module._compile (module.js:467:26)
    at Object.require.extensions..coffee (/Users/nathansobo/github/atom/node_modules/coffee-cache/lib/coffee-cache.js:48:17)
    at Module.load (module.js:367:32)
    at Function.Module._load (module.js:323:12)
    at Module.require (module.js:375:17)
    at require (module.js:391:17)
    at window.onload (file:///Users/nathansobo/github/atom/static/index.html:16:9)", source: file:///Users/nathansobo/github/atom/static/index.html (22)
@zcbenz
Copy link
Member

zcbenz commented Jul 26, 2013

atom-shell allocates an ID for each remote object and just stores it by assigning the ID to object's id property, this is absolutely stupid and would get atom-shell into bad state when an object already has an id property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants