Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version chooser uses latest included version rather than latest online version as default #173

Open
nornagon opened this issue Feb 8, 2019 · 2 comments
Labels
✨ enhancement New feature or request

Comments

@nornagon
Copy link
Member

nornagon commented Feb 8, 2019

To repro:

  1. install on fresh machine
  2. look at top-left corner for current electron version
  3. observe "Electron v4.0.0-beta.10"

Fiddle should probably default to whatever electron@latest is on npm :)

@felixrieseberg
Copy link
Member

Fiddle should probably default to whatever electron@latest is on npm :)

Easier said than done, at least without introducing a decent amount of complexity. The list of Electron releases is downloaded on the fly and changing the default value after the fact would require using mutliple version states.

@felixrieseberg felixrieseberg added the ✨ enhancement New feature or request label Feb 20, 2019
@felixrieseberg felixrieseberg changed the title Default version on first install is 4.0.0-beta.10 instead of 4.0.4 Version chooser uses latest included version rather than latest online version as default Feb 20, 2019
@erickzhao
Copy link
Member

Could we fetch the latest version from the NPM version with the latest-version package (link) and attempt to set that version from the version list as the default?

I can see it working well for the purposes of the issue. However, I don't know if we want to add yet another dependency to Fiddle's package.json.

cc @felixrieseberg @nornagon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants