Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support electron < 1.8.x #60

Closed
bpasero opened this issue Aug 10, 2018 · 4 comments
Closed

Support electron < 1.8.x #60

bpasero opened this issue Aug 10, 2018 · 4 comments
Labels
🪲 bug Something isn't working

Comments

@bpasero
Copy link
Contributor

bpasero commented Aug 10, 2018

It looks like the code in main does not execute when you pick Electron < 1.8.x, due to the missing loadFile method:

image

@savokiss
Copy link

We need electron 1.6.5, seems like there are no options 😶

@felixrieseberg felixrieseberg added the 🪲 bug Something isn't working label Aug 17, 2018
@malept
Copy link
Member

malept commented Aug 20, 2018

I think it's more complicated than that:

  • Should Fiddle support version series of Electron that the core team does not maintain anymore?
  • If so, how far back does Fiddle need to support?
  • Should Fiddle provide boilerplate Electron code based on the version selected? For example, fix: Support Electron <1.8.x #77 makes it pretty clear that loadFile makes the code easier to read.

@malloxpb
Copy link
Contributor

I believe this issue has been resolved in #77 with modification from @felixrieseberg

@felixrieseberg
Copy link
Member

It was! Thank you for noticing, I'll close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants