Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft wrap for Fiddle #88

Closed
malloxpb opened this issue Aug 23, 2018 · 8 comments
Closed

Soft wrap for Fiddle #88

malloxpb opened this issue Aug 23, 2018 · 8 comments
Assignees

Comments

@malloxpb
Copy link
Contributor

Do you guys think it is a good idea to add Soft wrap feature for Fiddle text editor? I feel like it's kind of hard to see what I typed in the text editor without it 馃槃

@felixrieseberg
Copy link
Member

This is a good idea. I'll PR a thing!

@malloxpb
Copy link
Contributor Author

Sounds good! Thank you so much for that :)

@malloxpb
Copy link
Contributor Author

Actually is it possible that I work on this @felixrieseberg ? I am pretty new to Electron but I thought it might be a good chance for me to learn more 馃槃

@felixrieseberg
Copy link
Member

@nctl144 Please go ahead and don't hesitate to email me if you have any question! The Electron project can always use more hands 馃憦馃憦

@malloxpb
Copy link
Contributor Author

malloxpb commented Sep 2, 2018

Thank you so much for the encouragement, @felixrieseberg . Do you have any specific email address so that I can connect to you?

@felixrieseberg
Copy link
Member

Hit me up at felix@felixrieseberg.com.

A small idea I had: We create editors with a set of options here. There are so many options 鈥撀燼nd people probably care about a lot of them. We could allow Fiddle users to edit a JSON file, similar to how Visual Studio Code handles options.

It'd be a slightly bigger project, but you could steal a lot of code from how we handle custom themes. No pressure, just adding the soft wrap is fine, too 鈥撀燽ut if you're interested in a juicy part, this would be a feature people would thank you so much for 馃

@malloxpb
Copy link
Contributor Author

malloxpb commented Sep 2, 2018

Sounds really good! I will work on that now haha

@felixrieseberg
Copy link
Member

This is now done and will be in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants