Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix for issue #2042 based on #667's solution #2138

Closed
3 tasks done
alex-drocks opened this issue Jan 27, 2021 · 1 comment
Closed
3 tasks done

Temp fix for issue #2042 based on #667's solution #2138

alex-drocks opened this issue Jan 27, 2021 · 1 comment
Labels

Comments

@alex-drocks
Copy link

alex-drocks commented Jan 27, 2021

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

  • Electron Forge Version:
    • 6.0.0-beta-54
  • Electron Version:
    • 11.2.1
  • Operating System:
    • Windows 10 pro, Version 20H2, released date 2020-09-15, 19042.746
  • Last Known Working Electron Forge version::
    • 6.0.0-beta-54 (with Electron v10)

Expected Behavior

npm run start should start the electron app as usual.

Actual Behavior

npm run start fails with Could not detect abi for version 11.0.1 and runtime electron.

To Reproduce

Not applicable: based on prior proof contained in issue #2042

Additional Information

  • I have followed issue node-abi needs to be updated #667's solution and it works.
  • To temporarily fix the issue on your machine without waiting for an official release of Forge, you can try deleting your project's node_modules completely and also the package-lock.json if you use npm (for yarn delete yarn lock or something similar).

  • Then, in your projects folder run npm install and it should not throw the node-abi error anymore.
@malept
Copy link
Member

malept commented Jan 27, 2021

This isn't really something that can be fixed in Electron Forge itself. As mentioned in other bugs, you need to update the node-abi dependency. Although as of electron-rebuild >= 2.3.4, node-abi is only called if there's actually a native module to rebuild.

@malept malept closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants