-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@electron/get suppresses 404 error #125
Comments
6.x are OK. |
When I use 'npm i elelctron@7.1.1' with ELECTRON_MIRROR=https://npm.taobao.org/mirrors/electron/, it leads to a response code 404 not found error Here is I how I fix it for temporary:
var path = mirrorVar('customDir', opts, details.version);
var path = mirrorVar('customDir', opts, details.version.replace(/v\./, ''); then run |
I test it just now. |
How about this issue's progress? |
I can't reproduce this @NaridaL. I get the appropriate 404 error in console when I test on my machine. |
@MarshallOfSound |
🎉 This issue has been resolved in version 1.7.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
After the issues in #124 I abandoned
electron-download
in favor of settingELECTRON_MIRROR="https://npm.taobao.org/mirrors/electron/"
as described in https://electronjs.org/docs/tutorial/installation#custom-mirrors-and-caches.After figuring out to also set
DEBUG=*
, I got the following log...It took setting a breakpoint on all exceptions, to figure out the underlying issue has nothing to do with permissions, but that the constructed URL is invalid, because
https://npm.taobao.org/mirrors/electron/
doesn't includev
s in front of the version! This leads to a HTTP 404, but it isn't logged anywhere.The docs should be improved and something done so that mirrors URLs can be used interchangeably, but in any case, electron/get needs to log HTTP errors.
The text was updated successfully, but these errors were encountered: