Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

miss word in notification-action.md #160

Closed
kstar0714 opened this issue Nov 18, 2017 · 6 comments
Closed

miss word in notification-action.md #160

kstar0714 opened this issue Nov 18, 2017 · 6 comments

Comments

@kstar0714
Copy link
Contributor

one word is miss. content/docs/api/structures/notification-action.md
incomptible -> incompatible
thanks

@welcome
Copy link

welcome bot commented Nov 18, 2017

👋 Thanks for opening your first issue here!

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Nov 18, 2017

Hey @kstar0714, this typo would have to be fixed in the original over at electron/electron. See https://github.com/electron/electron/blob/master/docs/api/structures/notification-action.md

Do you think you could give that a shot? 😄

@MarshallOfSound
Copy link
Member

Actually, this has already been fixed in the original 🤔

/cc @zeke Any ideas?

@zeke
Copy link
Contributor

zeke commented Nov 18, 2017

Yeah we need to run npm run collect to bring in the latest changes. That's not automated yet but it will be soon. Related: electron/electronjs.org-old#830

Also we're only pulling changes from the latest stable release of Electron on npm: #81

@kstar0714
Copy link
Contributor Author

kstar0714 commented Nov 19, 2017

Documents of crowdin site and documents of electron-i18n are some different. Please update it.
@zeke

@zeke
Copy link
Contributor

zeke commented Nov 19, 2017

This update will take effect the next time we pull in docs from electron. Closing.

@zeke zeke closed this as completed Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants