Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Please check crowdin comment #241

Closed
dakeshi opened this issue Feb 13, 2018 · 8 comments
Closed

Please check crowdin comment #241

dakeshi opened this issue Feb 13, 2018 · 8 comments

Comments

@dakeshi
Copy link
Contributor

dakeshi commented Feb 13, 2018

I left a comment to fix some typo errors in english source files but there are no reply for that and it has not changed yet.

Would I report those of issue on github issue instead of crowdin comment?

@welcome
Copy link

welcome bot commented Feb 13, 2018

👋 Thanks for opening your first issue here!

@vanessayuenn
Copy link
Contributor

@dakeshi typo fixes in English source content can be made via a PR against https://github.com/electron/electron/tree/master/docs on the electron repo.

@zeke
Copy link
Contributor

zeke commented Feb 13, 2018

Sorry we missed your comment on Crowdin, @dakeshi. Like @vanessayuenn said, electron/electron is the place to fix issues in the source content. A pull request would be much appreciated!

@zeke zeke closed this as completed Feb 13, 2018
@dakeshi
Copy link
Contributor Author

dakeshi commented Feb 14, 2018

The reason why I leave comments on crowdin instead of github issue, crowdin is uni-directional sync. (from crowdin to github). If you prefer to PR for typo errors, I'll do that.

@dakeshi
Copy link
Contributor Author

dakeshi commented Feb 14, 2018

I create PR #243 for typo.

@dakeshi
Copy link
Contributor Author

dakeshi commented Feb 14, 2018

Would you give a proof reader role for korean translation? it would be helpful to make better translation.

@zeke
Copy link
Contributor

zeke commented Feb 14, 2018

Would you give a proof reader role for korean translation?

✅ Done. Thanks for helping out!

@dakeshi
Copy link
Contributor Author

dakeshi commented Feb 14, 2018

Thanks. Here is recreated PR in electron/electron#11918

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants