-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiled binaries downloaded by mksnapshot broken? #3
Comments
Any news? :( |
@hypersad which version of |
@kewinsawicki I need mksnapshot for building Atom. Defined electronVersion to 1.6.0 and mksnapshot to ~1.6 in package.json. |
@hypersad can you try setting running: npm --arch=armv7l --platform=linux install electron-mksnapshot@1.6.0 and see if that downloads the right version? |
I'll try it when i come home, but didn't think that it help me, because I tried some versions from china mirror and they returns Intel 80836 |
Still getting Intel 80836 binaries... |
@hypersad can you download https://github.com/electron/electron/releases/download/v1.6.0/mksnapshot-v1.6.0-linux-armv7l.zip directly and confirm it works as expected? |
Again Intel 80836, again 'Exec format error'... |
Any news? We need mksnapshot for trying to build Atom on armv7l :( |
Maybe I should create an issue in electron? |
@hypersad I made an issue electron/electron#11413 because I didn't know mksnapshot had its own repository. This problem has not yet been fixed, and now your unmaintained repository no longer builds -- not your fault, that's what unmaintained means. :-) I am hopeful that whoever does maintain mksnapshot can somehow get it to build for ARM now that electron-packager supports ARM, because I think that's the last roadblock preventing master-branch Atom from being compiled for armv7l. |
@jkleinsc is actively working on resolving the mksnapshot issue, and I believe he cut a new release today. |
I find that very exciting! What can I do to test it? |
Starting with version 1.8.5 (as well as 2.0.0-beta7), we changed how we distribute the arm/arm64 binaries of mksnapshot. There are now 4 files for arm/arm64 mksnapshot, for example the following from the 2.0.0 release:
Because of these changes, when you now run npm install with an |
Looks like mksnapshot compiled binaries downloaded by electron-mksnapshot wrong compiled. When I downloading prebuilt binaries for arm/armv7l I got Intel 80836 binaries.
file mksnapshot
output:mksnapshot: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.26, BuildID[sha1]=8b1a63cf158c934666279b6539cfa945502264c5, not stripped
So, I'd like to compile mksnapshot separately from Electron on my machine, where i can found sources for it?
The text was updated successfully, but these errors were encountered: