Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Node Module version out of synch with official Node.JS distribution #20

Closed
mike-lischke opened this issue Oct 15, 2016 · 5 comments
Closed

Comments

@mike-lischke
Copy link

The current node module version used in this repo is 49 (as of commit 3ce8afa), however the current module version of the latest Node.JS package is 48 (https://nodejs.org/en/download/releases/), which makes it impossible to build native modules for use in applications that check for the node module version (e.g. Visual Studio Code).

Please reconsider your decision to allow deviating from the version of the official Node.JS distribution.

@addaleax
Copy link
Contributor

fwiw, here is a schedule of Node module versions for electron, and Node v7 will come out using a module version of 51, so at least they will align up again soon.

@MarshallOfSound
Copy link
Member

which makes it impossible to build native modules for use in applications that check for the node module version (e.g. Visual Studio Code).

I'm not sure what you mean by this, building native modules for electron is thoughouly documented in the Electron repo: https://github.com/electron/electron/blob/master/docs/tutorial/using-native-node-modules.md

@mike-lischke
Copy link
Author

I see, standard node-gyp builds might not work. I only wish the tutorial would also address Windows. I'll give that a try and will close this issue once I confirmed that the native module works using that approach. Thanks.

@MarshallOfSound
Copy link
Member

I see, standard node-gyp builds might not work.

No, they do not. This is because Electron's V8 version is linked to Chromium's V8 version rather than Node's. You would always need to recompile with the correct headers.

@mike-lischke
Copy link
Author

mike-lischke commented Oct 17, 2016

Ok, that's all been my fault. If the docs say compile with electron-gyp then do it :-) Works fine for me now. Thanks for a great product!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants