feat: add support for and document --deep for subresources #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
reviewed
May 14, 2024
| @@ -286,6 +288,10 @@ async function signApplication (opts: ValidatedSignOptions, identity: Identity) | |||
| perFileArgs.push('--options', [...new Set(optionsArguments)].join(',')); | |||
| } | |||
|
|
|||
| if (perFileOptions.additionalArguments) { | |||
| perFileArgs.push(...perFileOptions.additionalArguments); | |||
There was a problem hiding this comment.
Question: doesn't this allow users to override the args that we're setting, and how bad would that be?
There was a problem hiding this comment.
doesn't this allow users to override the args that we're setting
This operation is additive, meaning that all our existing args will be set. This just allows folks to provide "additional" arguments.
erikian
approved these changes
May 14, 2024
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docs, example and impl for using
--deepin the "right" way.Fixes #240