-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to write to info.plist or custom info.plist for OSX #136
Comments
I also had to add other properties than the ones that electron packager provides and ended up forking electron-packager to add options. But this doesn't scale. I kind of like the idea of specifying a custom plist, since it gives you the best control of what to add, without having to change the packager for every property. So instead of creating the plist on the fly, you would just copy this into the app folder. |
what about an optional handler that would pass the psedocode: packager({
...
plist: function(plist) {
plist.CFBundleURLTypes = [{
CFBundleURLName: 'OpenHelper',
CFBundleURLSchemes: [ 'custom' ]
}];
return plist;
}
...
}, cb); Note: I don't know enough about |
@dylang my general feedback on the idea is that this sounds like something that should be solved outside of this module first, and we can support an API for doing this that someone else can maintain :) |
@maxogden Do you mean like plist? I didn't realize you were already using it. I should have looked, very nice. It looks like it's making managing the plist much easier. Or do you mean a module with an api specific to the available |
@dylang ah sorry, I was talking about the latter part -- the specific info.plist configuration stuff |
@buddingmonkey @herrmannplatz I just realized the feature I wanted, protocols (custom url handlers) already exists, it's just not yet documented (and possibly not officially supported): https://github.com/maxogden/electron-packager/blob/master/mac.js#L62-#L69 Example usage: packager({
....
protocols: [{
name: 'Some Name',
schemes: ['foo'] //foo://google.com will launch your app
}]
), cb); Hope that might help unblock you. |
Re: protocols documentation, there is an issue at #121. |
@dylang Protocols are a good start, but also file handlers would be nice. Even if we can't use a custom info.plist file, maybe we could specify additional parameters. This would allow for generic additions to the plist. |
I think the custom info.plist parameters are definitely a good start. It would cover future changes to properties (including new properties) on apples side without having to change electron-packager. |
See #253 |
Since #253 has been merged, I'm closing this issue. |
The packager should be able to allow us to specify parameters (e.g. file extensions and protocols) or allow us to provide a custom info.plist so we can have tighter integration with the OS.
The text was updated successfully, but these errors were encountered: