feat: set asar integrity resource on windows packages #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
==========================================
- Coverage 89.29% 89.09% -0.20%
==========================================
Files 17 17
Lines 897 899 +2
Branches 186 187 +1
==========================================
Hits 801 801
- Misses 60 61 +1
- Partials 36 37 +1 ☔ View full report in Codecov by Sentry. |
erickzhao
reviewed
Mar 27, 2024
erickzhao
approved these changes
Mar 27, 2024
MarshallOfSound
force-pushed
the
asar-integrity-windows
branch
from
c810846
to
1b7f0bb
Compare
|
🎉 This PR is included in version 18.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently targeting my "remove rcedit" branch so that the diff is small and makes sense.
Pretty straight forward, sets the right asar integrity resource when packaging for windows.