Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Application Package Untrusted #245

Closed
ryanpager opened this issue Jan 25, 2016 · 3 comments
Closed

Windows Application Package Untrusted #245

ryanpager opened this issue Jan 25, 2016 · 3 comments
Labels
build-host:windows Running Electron Packager on Windows build-target:windows Bundling an Electron app specifically for Windows question ❓ Question about using Electron Packager. Not supported in this issue tracker.

Comments

@ryanpager
Copy link

So I used the electron packager to create a windows bundle, and what not -- everything works great. But when people launch the application windows 7+ complains that the application is untrusted.

Is there some sort of certificate I need, or some sort of signing process I need to follow? I can't seem to figure this out, and having people complain that it is unsafe is a little annoying.

@malept malept added question ❓ Question about using Electron Packager. Not supported in this issue tracker. build-target:windows Bundling an Electron app specifically for Windows build-host:windows Running Electron Packager on Windows labels Jan 25, 2016
@malept
Copy link
Member

malept commented Jan 25, 2016

electron-packager does not currently have signing support for Windows packages (see #32). However, we are more than happy to review and merge a pull request to add this feature.

@malept malept closed this as completed Jan 25, 2016
@MarshallOfSound
Copy link
Member

@malept In regards to a PR adding this feature, how do you feel about including the "signtool" binary like electron-installer-windows have?

@malept
Copy link
Member

malept commented Feb 13, 2016

@MarshallOfSound

Could you please explain what you mean by "include"? In any event, the better choice for this would be to write a Windows signing node module and then create a pull request for electron-packager to integrate with it (similar to how OSX signing is being developed in #223).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-host:windows Running Electron Packager on Windows build-target:windows Bundling an Electron app specifically for Windows question ❓ Question about using Electron Packager. Not supported in this issue tracker.
Projects
None yet
Development

No branches or pull requests

3 participants