Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow yarn to be used instead of npm #518

Closed
soredake opened this issue Oct 28, 2016 · 8 comments
Closed

Allow yarn to be used instead of npm #518

soredake opened this issue Oct 28, 2016 · 8 comments
Labels
blocked 🚫 Depends on another issue either in this project or a dependency's project enhancement Feature request has-pull-request

Comments

@soredake
Copy link

Lines like this preventing normal use with yarn:
child.exec('npm prune --production', {cwd: appPath}, cb)
exec('npm install --no-bin-links'

@malept
Copy link
Member

malept commented Oct 28, 2016

That's preventing yarn completely replacing npm, sure. In the meantime you should be able to symlink npm to yarn and in theory it should "just work".

@malept malept added enhancement Feature request help wanted Needs a contributor from the community labels Oct 28, 2016
@malept malept changed the title yarn support Support custom NPM-compatible package managers Oct 28, 2016
@soredake
Copy link
Author

yarn prune has no --production option
yarn install has no --no-bin-links option, so just symlink is not the solution (while sed -i /npm --option/yarn --option, but it is not so convenient)

@malept
Copy link
Member

malept commented Oct 28, 2016

Then it sounds like yarn support specifically is blocked on prune --production being added. That is an important part of how we package Electron apps.

@soredake
Copy link
Author

@malept malept changed the title Support custom NPM-compatible package managers Allow yarn to be used instead of npm Oct 30, 2016
@malept malept added the blocked 🚫 Depends on another issue either in this project or a dependency's project label Oct 30, 2016
@malept
Copy link
Member

malept commented Oct 30, 2016

The above yarn issue relates to prune. This one relates to --no-bin-links: yarnpkg/yarn#929

Those two issues block proper yarn support. However, I have spec'd out how to implement generic NPM-compatible package manager support in #515 (comment), and I am happy to review pull requests that implement this (and, obviously, follow the contributing guidelines).

@soredake
Copy link
Author

soredake commented Nov 3, 2016

yarnpkg/yarn#1651

@soredake
Copy link
Author

soredake commented Nov 4, 2016

@ghost
Copy link

ghost commented Mar 14, 2017

--no-bin-links did finally happen, but still no resolution for the other issue.

@malept malept added has-pull-request and removed help wanted Needs a contributor from the community labels Mar 20, 2017
@hrkt hrkt mentioned this issue Apr 24, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked 🚫 Depends on another issue either in this project or a dependency's project enhancement Feature request has-pull-request
Projects
None yet
Development

No branches or pull requests

2 participants