Use launcher.bat instead of a go binary for windows

The launcher binary written in go was frequently marked as a trojan or virus. A simple bat file should seen as more innocuous. See #93 for the problem as well as this bat file. Proof that the bat file will be marked as safe: https://www.virustotal.com/en/file/1d86bd7934a6628d34458708ae435d4decefb671d51e262ad1f8d7f66ae89542/analysis/1495475045/ Proof that launcher.exe is marked as malicious: https://www.virustotal.com/en/file/dee7112c53b6bd2509ec23c5c6b4f17c65210684789510fa4caf6d3ff4c66949/analysis/
electron-userland · May 22, 2017 · d74b5a0 · d74b5a0
1 parent ae97a82
commit d74b5a0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 35 deletions.
diff --git a/bin/README.md b/bin/README.md
diff --git a/bin/launcher.exe b/bin/launcher.exe
diff --git a/lib/application.js b/lib/application.js
@@ -150,12 +150,8 @@ Application.prototype.createClient = function () {
       args.push(arg)
     })
 
-    var launcherPath = null
-    if (process.platform === 'win32') {
-      launcherPath = path.join(__dirname, '..', 'bin', 'launcher.exe')
-    } else {
-      launcherPath = path.join(__dirname, 'launcher.js')
-    }
+    const isWin = (process.platform === 'win32')
+    const launcherPath = path.join(__dirname, isWin ? 'launcher.bat' : 'launcher.js')
 
     if (process.env.APPVEYOR) {
       args.push('no-sandbox')

diff --git a/lib/launcher.bat b/lib/launcher.bat
@@ -0,0 +1,4 @@
+@echo off
+"%SPECTRON_NODE_PATH%" "%SPECTRON_LAUNCHER_PATH%" %*
+if ERRORLEVEL 1 exit /b 1
+exit /b 0
diff --git a/lib/launcher.go b/lib/launcher.go