should getFocusedWebContents() have return type 'WebContents | null'?

[kevinushey]

My electron.d.ts (from version 17.1.0) has:

    /**
     * The web contents that is focused in this application, otherwise returns `null`.
     */
    static getFocusedWebContents(): WebContents;

IIUC, because this function can return null, the return value should be declared as WebContents | null. Or am I misunderstanding something?

[erickzhao]

I think you're right. This should be fixed in the documentation itself over in the main Electron repo. :)

[kevinushey]

Thanks! It wasn't quite clear to me where and how electron.d.ts is generated, so I filed the issue here first -- should I close this and re-open at https://github.com/electron/electron/issues?

[erickzhao]

Feel free to make a documentation PR directly. It should look something like this:

In docs/api/web-contents.md

- Returns `WebContents` - The web contents that is focused in this application, otherwise
+ Returns `WebContents` | null - The web contents that is focused in this application, otherwise
returns `null`.

[kevinushey]

Thank you :-) I'll do that!