Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

character corruption in EASTL header files. #71

Closed
dAu6jARL opened this issue Nov 30, 2016 · 3 comments
Closed

character corruption in EASTL header files. #71

dAu6jARL opened this issue Nov 30, 2016 · 3 comments
Labels
help wanted

Comments

@dAu6jARL
Copy link
Contributor

dAu6jARL commented Nov 30, 2016 •
edited

Two character corruptions exist in EASTL header files.

  • include/EASTL/optional.h
    U+2019 UTF8 character "’" exists in line 15. I suggest replace U+2019 by 0x27.
    // object of type T, referred to as the optional object’s contained value, is allocated
    suggest: ’ to '

  • include/EASTL\internal/type_pod.h
    Illegal latin-1 tilde 0x98(U+02DC) is used in line 1670. Legal tilde is 0x7e.
    C4819 warning will occurs in non latin-1 version Visual Studio.
    I see this warning in Japanese version VS2017RC.
    // test<T>::˜test() is not deleted (C++11 "= delete").
    suggest: ˜ to ~
@rparolin
Copy link
Contributor

rparolin commented Dec 1, 2016

Thanks for reporting this. If you submit a PR I'll merge it.

@dAu6jARL
Copy link
Contributor Author

dAu6jARL commented Dec 1, 2016

Sorry, I am unfamiliar with Git and "pull request".
Instead of PR, I attach two corrected candidate files as a ZIP file "candidate.zip".
Thank you.

candidate.zip

@rparolin
Copy link
Contributor

rparolin commented Dec 1, 2016

Sorry, I'd prefer if you submitted a PR. There are a ton of tutorials online.

rparolin pushed a commit that referenced this issue Dec 2, 2016
@dAu6jARL @rparolin
Mojibake in EASTL header files. #71 (#74)
20e97f2 
* Update optional.h

U+2019 UTF8 character "’" exists in line 15. I replace U+2019 by 0x27.

* Update type_pod.h

Latin-1 tilde 0x98(U+02DC) is used in line 1670.
To resolve C4819 warning in non latin-1 version Visual Studio, replace it normal tilde 0x7e.
@rparolin rparolin closed this as completed Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rparolin @dAu6jARL