Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Convert to JS #2

Merged
merged 8 commits into from Jul 26, 2015
Merged

Convert to JS #2

merged 8 commits into from Jul 26, 2015

Conversation

benogle
Copy link
Contributor

@benogle benogle commented Jul 26, 2015

No description provided.

benogle added a commit that referenced this pull request Jul 26, 2015
@benogle benogle merged commit 58562bd into master Jul 26, 2015
@benogle benogle deleted the bo-to-js branch July 26, 2015 03:14
@thomasjo
Copy link

Do we really want to use ASI? I'm personally 👎 due to obvious reasons related to well known issues with ASI. Always explicitly using semicolons never causes any problems, but omitting them frequently does, hence I suggest that omitting them is not worth it.

I'll gladly add the semicolons myself.

@mnquintana
Copy link

I agree with @thomasjo on this - I desperately want to not use semicolons in JS, but ASI (at least as implemented by every JS interpreter) is janky as hell. One of the cases I'd expect us to run into a lot is with array destructuring, if we did something like:

let [thing, thing2] = arrayOfThings
[thing] = otherArrayOfThing

It would be interpreted as:

let [thing, thing2] = arrayOfThings[thing] = otherArrayOfThing

Which could be avoided by prepending that like with a ;, but that would be awful.

One thing I'd still like to do one of these days would be to write a Babel plugin that does ASI for you with a much better algorithm, but until such a plugin exists, I think our code would be safer and more consistent by just using semicolons everywhere, unfortunately. 😕

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants