Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MALOC modernization #23

Open
sobolevnrm opened this issue Apr 24, 2020 · 6 comments
Open

MALOC modernization #23

sobolevnrm opened this issue Apr 24, 2020 · 6 comments
Assignees

Comments

@sobolevnrm
Copy link
Member

It's no longer needed and takes extra effort to maintain.

@sobolevnrm sobolevnrm transferred this issue from Electrostatics/apbs-pdb2pqr Jul 3, 2020
@sobolevnrm
Copy link
Member Author

The most likely modernization route here is just to delete the library.

@ashermancinelli
Copy link
Collaborator

This issue is being developed in branch remove-maloc-dev

@ashermancinelli
Copy link
Collaborator

@sobolevnrm In the branch mentioned above, I've removed maloc as a dependency. I haven't changed too much, just copied five header/source pairs into another subdirectory of src. Would you like to iteratively replace the remnants of maloc as well or are we content with this solution?

CC @intendo

@sobolevnrm
Copy link
Member Author

I don't think we need to rewrite MALOC. If native functionality is available to replace MALOC functionality, then that's all we need.

@ashermancinelli
Copy link
Collaborator

ashermancinelli commented Oct 10, 2020

So would you like to leave a few components of maloc in the repo like in remove-maloc-dev branch? If we go the native functionality route, we'd probably want to refactor pieces of apbs source into C++. Biggest MALOC component used is Vio/socket stuff I think, we could replace all that with std::string. APBS/MALOC sources seem compile-able in C++ already anyways, but you know better than I if it would be too invasive to convert to c++.

@sobolevnrm
Copy link
Member Author

sobolevnrm commented Oct 11, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants