Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pHs are not pKas #37

Closed
sobolevnrm opened this issue Dec 6, 2015 · 2 comments
Closed

pHs are not pKas #37

sobolevnrm opened this issue Dec 6, 2015 · 2 comments
Assignees

Comments

@sobolevnrm
Copy link
Member

The --ph-calc-method option is incorrect. It should be --pka-calc-method. I've attached a main.py that may fix some of this (at least the problems with the option name and description).

Here's a fixed description but it should be fixed elsewhere, too:

pka_group.add_option('--pka-calc-method', dest='pka_calc_method', metavar='PH_METHOD', choices=('propka', 'pdb2pka'),
                 help='Method used to calculate pKa values. If a pKa calculation method is selected, titratable residue pKa values will be calculated and the residue potentially modified after comparison with the pH value supplied by --with_ph\n'
                 'propka - Use PROPKA to calculate pKa values. Actual PROPKA results will be output to <output-path>.propka.\n'
                 'pdb2pka - Use PDB2PKA to calculate pKa values. Requires the use of the PARSE force field.'
                 'Warning: Larger residues can take a very long time to run using this method. EXPERIMENTAL!')
@kmonson
Copy link
Contributor

kmonson commented Dec 7, 2015

Changes will need to be made to runPDB2PQR to make the keyword args consistent with the option name.

Both the OPAL and non OPAL code paths will need to be updated in main_cgi.py especially in the WebOptions class.

When the next release with this change we'll need to work with Nadya to setup testing on OPAL and make sure the OPAL stuff works correctly.

@sobolevnrm sobolevnrm assigned sobolevnrm and unassigned lizutah Apr 19, 2020
@sobolevnrm sobolevnrm transferred this issue from Electrostatics/apbs-pdb2pqr Jul 3, 2020
@sobolevnrm
Copy link
Member Author

This was fixed a long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants