Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sophisticated electrumsv-sdk "stop" command #15

Closed
AustEcon opened this issue Jul 30, 2020 · 1 comment
Closed

More sophisticated electrumsv-sdk "stop" command #15

AustEcon opened this issue Jul 30, 2020 · 1 comment
Labels

Comments

@AustEcon
Copy link
Contributor

With the introduction of the StatusServer (and websocket) coming soon... I think the "stop" command needs to become more sophisticated to specify which ComponentType(s) it wants to stop.

By default (no args) it kills all processes that were started

I think instead it would leave the status server running (but kill the rest) until it is explicitly stopped via:

electrumsv-sdk stop status_server

or

electrumsv-sdk stop all

Currently the stop command just iterates through all of the ComponentTypes that it started and kills them all indiscriminately.

Instead each ComponentType (with pid attached) should be looked up and killed selectively depending on arguments to the "stop" command.

This allows the front-end to maintain the 'link' of being able to check the status (with the default usage pattern)

@AustEcon
Copy link
Contributor Author

resolved in 2849e94

However, this needs to be made more granular to address requirements for:
#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant