Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK CLI - avoid starting and stopping ESV the first time merely to generate config files etc. #36

Closed
AustEcon opened this issue Oct 11, 2020 · 4 comments
Labels

Comments

@AustEcon
Copy link
Contributor

Instead could copy-paste the required files / create required directories (which should obviate a significant chunk of code and cut down on run time of pipelines tests.)

@rt121212121
Copy link
Contributor

This is a bad idea. It means that any incompatible changes become roadblocks to progress.

@AustEcon
Copy link
Contributor Author

AustEcon commented Oct 12, 2020

Okay. Are you aware that it's only empty directories (cache, certs, wallets) that I'm copy-pasting and config is:

    "config_version": 2,
    "rpcpassword": "",
    "rpcuser": "rpcuser"

There is no wallet database file or anything so the only time this would need to be updated would be if directory structure was altered. But I take your point. It was just so awful though starting and stopping the ESV daemon in order to create the needed files/directories and then disable basic auth for the API!

BUT I think I can remove the copy-pasting as well if I fix this bug:
electrumsv/electrumsv#111

Then can disable basic auth for the rest api AFTER initial launch of the daemon.

@rt121212121
Copy link
Contributor

No, I was under the impression that the whole point was to pre-create a wallet to reuse in order to avoid doing it on-demand.

@AustEcon
Copy link
Contributor Author

Okay cool 😃

Still though - I would like to fix that bug one of these days to completely refactor this all away to nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants