Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2PK script type not included in wallet restoration search #1041

Open
drnick30 opened this issue Feb 2, 2023 · 12 comments
Open

P2PK script type not included in wallet restoration search #1041

drnick30 opened this issue Feb 2, 2023 · 12 comments
Assignees
Labels

Comments

@drnick30
Copy link

drnick30 commented Feb 2, 2023

Describe the problem
I imported my 2012 btc key into electrum to claim the bsv fork, but it doesn't show up. I can see the coins on the explorer but it doesn't show up in electrumsv.

Desktop (please complete the following information):

  • ElectrumSV version: 1.3.15
  • OS: macos
  • Version ventura

https://bsv.tokenview.io/en/address/18eXJskHRVvKrqmxD9T6K6UQ6GBC6ya2WS
IMG_7078

@drnick30 drnick30 changed the title Importing a 2012 BTC key doesn't show BSV in electrum. Importing a 2010 BTC key doesn't show BSV in electrum. Feb 2, 2023
@rt121212121
Copy link
Contributor

When you paste in the key into the "import from text" user interface, what type of key does it say it is?

If it is BIP39, then there is an advanced or customize option, have you tried different derivation paths?

@drnick30
Copy link
Author

drnick30 commented Feb 2, 2023

It shows private key.

From the earlier screenshot, it shows the last 3 transaction but not the coinbase transaction of 50bsv.

Electroncash successfully showed the bch but electrumabc didn't show the xec. Does this have to do with how old the coins are? cant electrumsv query 2010 coins?

Screenshot 2023-02-02 at 10 36 44 PM

@drnick30
Copy link
Author

drnick30 commented Feb 2, 2023

What I find strange is that some explorers don't show the coins. like this one https://whatsonchain.com/address/18eXJskHRVvKrqmxD9T6K6UQ6GBC6ya2WS.

But you can clearly see it here https://bchsvexplorer.com/address/18eXJskHRVvKrqmxD9T6K6UQ6GBC6ya2WS and here https://bsv.tokenview.io/en/address/18eXJskHRVvKrqmxD9T6K6UQ6GBC6ya2WS

@drnick30
Copy link
Author

drnick30 commented Feb 2, 2023

Any help? Maybe i need to tweak Electrumsv somehow?

@drnick30
Copy link
Author

drnick30 commented Feb 2, 2023

I don't understand. The coins are on the blockchain, but electrumsv can't see them. Why is Bsv so different?

@rt121212121
Copy link
Contributor

The way ElectrumSV finds the transactions is by:

  1. Converting the private key to a public key.
  2. Making a P2PKH output script for the public key.
  3. Asking the indexer if it has seen that output script.

If you get back 3 of 4 transactions paying to (or spending from) that output script, then the indexer knows about that script, but those transactions may be all it has. Or ElectrumSV gets the coinbase match from the indexer but fails to process it for some reason. Without further information it is not possible to say why.

I suggest you turn on full logging and make a new wallet and restore that private key. Then provide that logging and we will see what we can see.

@drnick30
Copy link
Author

drnick30 commented Feb 2, 2023

No those transactions are not all. Look at the address on the blockchain I sent earlier https://bchsvexplorer.com/tx/e791dd210ff6cfff912d6b1c6f4194df6ef79485580a01335b8e4840a5cf1940

The coinbase transaction of 50BSV doesn't show up in electrumsv.

How do I turn on full logging?

@drnick30
Copy link
Author

drnick30 commented Feb 2, 2023

Importing the address 18eXJskHRVvKrqmxD9T6K6UQ6GBC6ya2WS only still doesn't work. Could you please import the address in electrum and see what I am talking about?

@rt121212121
Copy link
Contributor

When you run ESV, do it from the command-line, and add -v=debug as a command-line argument.

@drnick30
Copy link
Author

drnick30 commented Feb 3, 2023 via email

@drnick30
Copy link
Author

drnick30 commented Feb 4, 2023

Nevermind, here's the log https://pastebin.mozilla.org/oRAvO8Lf/raw

Also, the address is a p2pk and not p2pkh. Could this be the reason electrum sv cannot decode the coinbase transaction?

@rt121212121
Copy link
Contributor

It looks like P2PK is not included in the script types it looks for.

https://github.com/electrumsv/electrumsv/blob/releases/1.3/electrumsv/wallet.py#L1924

@rt121212121 rt121212121 self-assigned this Feb 6, 2023
@rt121212121 rt121212121 changed the title Importing a 2010 BTC key doesn't show BSV in electrum. P2PK script type not included in wallet restoration search Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants